search

vivaxy / vscode-conventional-commits

💬Conventional Commits for VSCode.
https://marketplace.visualstudio.com/items?itemName=vivaxy.vscode-conventional-commits
MIT License
320 stars 35 forks source link

[BUG] Missing icon after VSCode update 1.56 #160

Closed deoomen closed 3 years ago

deoomen commented 3 years ago

Describe the bug

After last VSCode update which changes icons, Conventional Commits plugin icon is also not rendering correctly. There is only a few pixels in heigh where you can click on it.

To reproduce

Steps to reproduce the behavior:

  1. Update VSCode to 1.56.
  2. Install Conventional Commits plugin.
  3. Go to Source Control tab.
  4. See missing icon (only little lighter small dot instead icon).

Expected behavior

Default Conventional Commits plugin icon should be rendered.

Screenshots

image image

Application logs

[info] Extension Activated
[info] vscode.env.language: en
[info] last used version: 1.21.0
[info] Conventional commits started.
[info] VSCode version: 1.56.0
[info] Git version: 1.0.0
[info] VSCode Conventional Commits version: 1.21.0
[info] conventionalCommits.autoCommit: true
[info] conventionalCommits.emojiFormat: code
[info] conventionalCommits.gitmoji: true
[info] conventionalCommits.lineBreak: 
[info] conventionalCommits.promptBody: true
[info] conventionalCommits.promptFooter: true
[info] conventionalCommits.promptScopes: true
[info] conventionalCommits.showEditor: false
[info] conventionalCommits.showNewVersionNotes: true
[info] conventionalCommits.editor.keepAfterSave: false
[info] git.enableSmartCommit: false
[info] git.smartCommitChanges: all
[info] git.postCommitCommand: none
yi-Xu-0100 commented 3 years ago

👋 @deoomen It works well in windows with v1.56.0. 😅

And it seems like not a dot but a small circle (default icon is a circle).

Which OS is you used? Ubuntu or any and the version ? 🧐

deoomen commented 3 years ago

Ubuntu 20.04.2 LTS

aleexnl commented 3 years ago

Same issue on MacOS Big Sur 11.3.1 With Visual Studio Code 1.56.1 image

yi-Xu-0100 commented 3 years ago

👋 @deoomen @aleexnl I don't think it's an extension issue. I think it's related to VS Code (https://github.com/microsoft/vscode/issues/123041). Our icon complies with VS Code's guidelines (16px SVG icon). I think we should wait for the new version to update to see whether there are similar issues afterward or not. 😅

aleexnl commented 3 years ago

Oh ok, for me issue is closed. Thanks for the help!

deoomen commented 3 years ago

After updating VSCode to 1.56.2 icon render properly. I close issue.

obraz obraz