search

vivaxy / vscode-conventional-commits

💬Conventional Commits for VSCode.
https://marketplace.visualstudio.com/items?itemName=vivaxy.vscode-conventional-commits
MIT License
324 stars 35 forks source link

[FEAT] Add "Closes" prompt #208

Open moltar opened 3 years ago

moltar commented 3 years ago

Is your feature request related to a problem? Please describe

Often you need to reference an issue that is being closed by the commit. All major git hosting platforms have support for acting on the commit message:

Describe the solution you'd like

  1. Add another prompt that requests to input a reference to an issue that is being closed.
  2. Add another setting to configure the closing pattern prefix (e.g. Closes or Fixes).

Describe alternatives you've considered

Used another extension that has support for this, but was otherwise buggy.

Additional context

The final commit message shall look like:

feat: short description

Long description.

Closes: #123456789
vivaxy commented 3 years ago

Thank you for your suggestion 👋.

This is an opinionated feature, which depends on the workflows.

For now, the footer section supports Closes #issue-id.

moltar commented 3 years ago

This is an opinionated feature, which depends on the workflows.

Makes sense.

Maybe then additional configurable footer prompts could be a more abstracted feature.

E.g. allow user to define an array of footer prompts:

{
  "prompt": "Which issues does it close?",
  "prefix": "Closes: "
}
vivaxy commented 3 years ago

Yes! It's a nice feature.

jfamousket commented 2 years ago

Any update on this, seems like a nice feature

julien-blanchon commented 2 years ago

A CLOSE prompt (and/or related prompt) would be great !

silopolis commented 1 year ago

Maybe then additional configurable footer prompts could be a more abstracted feature.

E.g. allow user to define an array of footer prompts:

{
  "prompt": "Which issues does it close?",
  "prefix": "Closes: "
}

This would open a world of possibilities for all kind of workflows. Lovin' it!