vivaxy / vscode-conventional-commits

๐Ÿ’ฌConventional Commits for VSCode.
https://marketplace.visualstudio.com/items?itemName=vivaxy.vscode-conventional-commits
MIT License
320 stars 35 forks source link

[BUG] Conventional Commits shows "Choose a repository" prompt every time #289

Closed zerodayyy closed 1 year ago

zerodayyy commented 1 year ago

Describe the bug

After upgrading to 1.24.4, the extension started to show a prompt "Choose a repository" on every action even when clicking the circle icon in "Source Control" panel:

image

This is annoying, since the button is already located under a specific repo in UI.

To reproduce

Steps to reproduce the behavior:

  1. Install Conventional Commits v1.24.4
  2. Open a Workspace with multiple Git-versioned folders
  3. Open Source Control view in side panel
  4. Click "Conventional Commits" circle icon
  5. Repo prompt is displayed

Expected behavior

Only commit message details are prompted

Screenshots

image

Application logs

Spoiler ``` [info] Conventional commits started. [info] VSCode version: 1.74.0 [info] Git version: 1.0.0 [info] VSCode Conventional Commits version: 1.24.4 [info] conventionalCommits.autoCommit: true [info] conventionalCommits.silentAutoCommit: false [info] conventionalCommits.emojiFormat: code [info] conventionalCommits.gitmoji: true [info] conventionalCommits.lineBreak: [info] conventionalCommits.promptBody: true [info] conventionalCommits.promptCI: false [info] conventionalCommits.promptFooter: true [info] conventionalCommits.promptScopes: true [info] conventionalCommits.scopes: redacted-1,redacted-2,redacted-3 [info] conventionalCommits.showEditor: false [info] conventionalCommits.showNewVersionNotes: false [info] conventionalCommits.editor.keepAfterSave: false [info] git.enableSmartCommit: true [info] git.smartCommitChanges: all [info] git.postCommitCommand: none [info] arg: undefined [info] git.repositories: /Users/zerodayyy/Redacted/redacted-repo-1, /Users/zerodayyy/Redacted/redacted-repo-2 [info] workspaceFolders: /Users/zerodayyy/Redacted/redacted-repo-1, /Users/zerodayyy/Redacted/redacted-repo-2 ```
yi-Xu-0100 commented 1 year ago

๐Ÿ‘‹ @zerodayyy, thanks for your report. ๐Ÿ˜

By the official reply, this is not a long-term fix, I will keep an eye on this issue and hopefully fix it permanently.

Now you can try the beta extension, please let me know if it still has other problems. ๐Ÿ˜Š

zerodayyy commented 1 year ago

Thanks, beta extension seems to work properly

yi-Xu-0100 commented 1 year ago

๐Ÿ‘‹ @zerodayyy, I am trying to figure out a long-term fix for this issue, and by referencing a similar type of VS Code extension (Git History), I resubmitted a PR#292 and generated a new beta extension (vscode-conventional-commits-ec78c36.vsix), hoping you can help and see if it has any other potential issues? ๐Ÿ˜

zerodayyy commented 1 year ago

@yi-Xu-0100 for sure, already installed it. I'll let you know if there are any other issues with it

yi-Xu-0100 commented 1 year ago

@zerodayyy I have published the changes to the new release v1.24.5, if you have any other questions, welcome to submit a new issue. ๐Ÿ˜Š