vivaxy / vscode-conventional-commits

💬Conventional Commits for VSCode.
https://marketplace.visualstudio.com/items?itemName=vivaxy.vscode-conventional-commits
MIT License
323 stars 35 forks source link

[FEAT] Using with Husky #306

Closed jonghyung-lee closed 1 year ago

jonghyung-lee commented 1 year ago

Is your feature request related to a problem? Please describe

First of all, thank you for developing this good extension. It's very useful.

However, it would be better if one feature could be added. It is a feature that allows to apply pre-commit hook through husky at the same time while using this extension. I am using pre-commit hook using husky, but currently, hook is triggered normally only when I commit through CLI. If I commit through this extension, the hook will not be triggered.

Is there any way already?

Describe the solution you'd like

A clear and concise description of what you want to happen.

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Additional context

Add any other context or screenshots about the feature request here.

vivaxy commented 1 year ago

Hi, @jonghyung-lee. This extension use VSCode git extension under the hood. Please check if VSCode git extension is able to run your pre-commit hook. Ref: https://code.visualstudio.com/docs/sourcecontrol/overview#_commit.

jonghyung-lee commented 1 year ago

Ok! I'll find the way! May I have to close this issue?

vivaxy commented 1 year ago

@jonghyung-lee Feel free to close this issue. You can reopen it when there are further questions.