search

vivchar / ViewPagerIndicator

A Simple View Pager Indicator with animations
92 stars 22 forks source link

Gradle update onSaveInstanceState and onRestoreInstanceState added #3

Closed GuilhE closed 6 years ago

GuilhE commented 6 years ago

Since void setSelectedIndex(final int selectedIndex) is a private method, I've added onSaveInstanceState() and onRestoreInstanceState(final Parcelable parcel). Even if setSelectedIndex becomes public, this state logic will spare us from the additional work ;)

vivchar commented 6 years ago

Hey, thank you for contribution, but looks like you changed the code style, please return it back and ping me

GuilhE commented 6 years ago

Changed Java code style indent to 8, instead of default 4, to match your code style

vivchar commented 6 years ago

Please see full changes, it does not help https://github.com/vivchar/ViewPagerIndicator/pull/3/files That is in red anyway =(

GuilhE commented 6 years ago

Hello, any news?

vivchar commented 6 years ago

Hi, I will do that manually later, because your changes contains a lot of codestyle changes. I need only onSave and onRestoreMethods.

GuilhE commented 6 years ago

Ok. I think you should be using the default configurations because if anyone want's to contribute you'll have the same problem over and over. The default Android Studio's Java code style indent is 4, your code uses 8.

If you change that, all you have to do next is to open your files and Control + Alt + L | Command + Option + L and you're done.

Cheers.