Tomatoes MovieListView Review

[vivekh-git]

My Tomatoes MovieListView is complete, please review. 2 known issues: a) ListView is not scrolling down even though scrolling is enabled in storyboard file. b) Model is not yet coded. Regarding Model for Movie, I was thinking that i would create a Mobie object that would have one single Movie details and construct a NSArray of Movie objects in MovieListViewController. Is that along the correct line of thinking ? /cc @nesquena @timothy1ee

[timothy1ee]

That's the right way to think about models. You should read and implement the feedback below. The point of this homework was to explore a simple example of a full MVC application with a RESTful API. Here's a few things I was looking for:

• Movie model. Did you have some way to create it from a dictionary?
• You should have implemented a custom cell. When creating a custom cell, make sure never to use imageView, titleLabel, or subtitleLabel. Those are already used by UITableViewCell and using them in your custom cell will cause subtle things to happen such as image views not loading until you click on the cell.
• If you chose to embed an image, you should have loaded the images asynchronously. One way to do that was to use AFNetworking, installed via CocoaPods.
• If you had an image, you should observe the UIContentMode of the UIImageView. By default, it will stretch the image to match your dimensions, which is probably not what you want.
• If you had a custom cell, you should configure the Auto Layout parameters. We'll review that in class.
• Optionally, you could have displayed some loading indicator while you were fetching the movies.
• Optionally, you could have displayed an error if you failed while fetching the movies. Preferably something better than the default UIAlertView. Check out what Twitter or Instagram does if there is a network error.
• Optionally, you could have created a MovieViewController which is launched if a user taps on a row. This will expose you to segues, especially since you'll want to set the movie on the MovieViewController to the one you tapped on. See this gist for a code snippet of how to set the movie: https://gist.github.com/timothy1ee/8393719.

[vivekh-git]

Tim -

1) i did create a custom cell (MovieCell) but fields may have overlapping names. I will rename the fields and see how it goes. 2) I do not yet know how to install a AFNetworking CocoaPod. Will read about it and use it in next rev. However i did use NSURLConnection and loaded images asynchronously. Is there anything wrong with the way i coded.

Let me focus on getting Model implemented. Fixing ImageStretching will be next. Other feedback implementation will follow.

Quick heads-up. I am working on temperature converter as well. I may not be able to implement all feedback by end of today. Hopefully, i get some time to get those done.

thanks, -Vivek

[timothy1ee]

Nothing is technically wrong with what you coded, but it's not very reusable. iOS apps have asynchronous image loading on every page usually. Imagine copying and pasting the code you wrote everywhere, and it doesn't support in memory caching of images you've already downloaded. You should use AFNetworking or another library to handle your image downloading.

Re: temperature converter, remember the class policy. If you have a late project, I'll change your status to an observer, we won't mentor your group project, and we'll ask that you follow the classes via recorded videos at your own pace.