Add support for Verilator as a diagnostic backend in Veridian

[hilbert-yaa]

Please refer to my feature request at #175.

The following changes are made:

• feat: add verilator to diagnostic backend options
• feat: display precise warning type info prepending to the lint message, e.g. "Warning-ASSIGNIN: <warning details>"
• chore: patch the lexical-core repository as an ad-hoc way to bypass the build issue on latest rustc toolchain

[vivekmalneedi]

Nice work, this looks really good! The patched version of lexical-core is an interesting idea as well. I attempted a full dep upgrade for #174 but the parser tests ended up being too brittle to get passing. A few requirements for this to be merged:

• passing CI
• there needs to be a test added for verilator (you'll need to install verilator in ci.yml)
• the readme needs to be updated to document the new config options

[hilbert-yaa]

Nice work, this looks really good! The patched version of lexical-core is an interesting idea as well. I attempted a full dep upgrade for #174 but the parser tests ended up being too brittle to get passing. A few requirements for this to be merged:

• passing CI
• there needs to be a test added for verilator (you'll need to install verilator in ci.yml)
• the readme needs to be updated to document the new config options

Thanks for the kind response. Sounds good I'll work towards these points.

[hilbert-yaa]

I realized that adding a "-Wno-context" arg to Verilator would make the get_diagnostic pass faster. Shall we default this Verilator arg (i.e. "hardcode" it) inside Veridian?

I'll work on resolving test and CI issues and also add some tests & docs tmr.

[vivekmalneedi]

I realized that adding a "-Wno-context" arg to Verilator would make the get_diagnostic pass faster. Shall we default this Verilator arg (i.e. "hardcode" it) inside Veridian?

That's a good idea, I was wondering if it had an option to made the output more machine-readable

[hilbert-yaa]

I realized that adding a "-Wno-context" arg to Verilator would make the get_diagnostic pass faster. Shall we default this Verilator arg (i.e. "hardcode" it) inside Veridian?

That's a good idea, I was wondering if it had an option to made the output more machine-readable

Yes exactly, with "-Wno-context" Verilator will not output code blame info on each error (but may still contain some non-error, non-warning lines if my memory serves), shrinking the output size by 2-3x. Thus it will reduce the latency on filtering (tho filtering is still needed).

[hakan-demirli]

Any update on this? I would like to fix the blockers.

[vivekmalneedi]

@hakan-demirli sorry for the delayed response. I don't believe that there are any blockers apart from rebasing the changes onto master and testing which I've created a new PR to complete.

[vivekmalneedi]

PR merged in #188