search

vivekrajenderan / simplesamlphp

Automatically exported from code.google.com/p/simplesamlphp
Other
0 stars 0 forks source link

Magic Quotes test broken on PHP >= 5.4 #543

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The test for whether Magic Quotes is enabled on frontpage_welcome is broken in 
PHP >= 5.4. The test uses a type strict comparison with whether 
get_magic_quotes_runtime returns 0, but in PHP 5.4 and later it returns FALSE, 
which fails the === test. This patch fixes that by using boolean logic that 
matches both.

Original issue reported on code.google.com by thijs@kinkhorst.com on 28 Mar 2013 at 9:25

Attachments:

GoogleCodeExporter commented 9 years ago 
Hi,

I thought this was fixed in r3166 (where the strict comparison was replaced 
with a loose comparison). Your patch description refers to a strict comparison, 
but your patch replaces a loose comparison, which leaves me a bit confused :)

Was the patch written for an older release, or isn't it working with the loose 
comparison?

Original comment by olavmrk@gmail.com on 3 Apr 2013 at 6:15

GoogleCodeExporter commented 9 years ago 
You're right, I found the issue in 1.9 but misported the fix to trunk. So the 
issue is indeed already solved.

Original comment by thijs@kinkhorst.com on 3 Apr 2013 at 10:01

GoogleCodeExporter commented 9 years ago 
OK, then I'll close this issue as fixed :)

Original comment by olavmrk@gmail.com on 3 Apr 2013 at 11:46