Revision r3107 does not seem to have been pulled into releases

[GoogleCodeExporter]

Hi,

I've just been hit by the minor bug that was fixed in r3107 
(http://code.google.com/p/simplesamlphp/source/detail?r=3107), and using this 
diff fixed the exception. I'm on version 1.11.0 so just highlighting that this 
revision may have got lost on its way to a release.

Thanks for a great product,

 - Chris

Original issue reported on code.google.com by squ...@gmail.com on 10 Oct 2013 at 3:30

[GoogleCodeExporter]

It is included in version 1.11:

    https://code.google.com/p/simplesamlphp/source/browse/tags/simplesamlphp-1.11.0/lib/SAML2/XML/md/IDPSSODescriptor.php#92

If line 92 still reads:

    $this->AssertionIDRequestService[] = new SAML2_XML_md_EndpointType($airs);

In your installation, you have an issue with your upgrade to 1.11.

(I also checked against the download, and the line is correct in the download 
as well.)

Original comment by olavmrk@gmail.com on 11 Oct 2013 at 6:34

[GoogleCodeExporter]

Apologies, my bug report was inaccurate. I actually had the problem in 
lib/SAML2/XML/md/AuthnAuthorityDescriptor.php which has the same style of 
issue/resolution but actually there's no matching revision. (Similar enough 
that I mistook r3107 to apply to this file).

index 8ab4c88..52124ab 100644
--- a/simplesamlphp/lib/SAML2/XML/md/AuthnAuthorityDescriptor.php
+++ b/simplesamlphp/lib/SAML2/XML/md/AuthnAuthorityDescriptor.php
@@ -58,7 +58,7 @@ class SAML2_XML_md_AuthnAuthorityDescriptor extends 
SAML2_XML_md_RoleDescriptor
                }

                foreach (SAML2_Utils::xpQuery($xml, './saml_metadata:AssertionIDRequestService') as $ep) {
-                       $this->AssertionIDRequestService[] = new 
SAML2_XML_md_EndpointType($airs);
+                       $this->AssertionIDRequestService[] = new 
SAML2_XML_md_EndpointType($ep);
                }

                $this->NameIDFormat = SAML2_Utils::extractStrings($xml, SAML2_Const::NS_MD, 'NameIDFormat');

Original comment by squ...@gmail.com on 11 Oct 2013 at 7:06

[GoogleCodeExporter]

Further,
lib/simplesamlphp/lib/SAML2/XML/md/PDPDescriptor.php 
lib/simplesamlphp/lib/SAML2/XML/md/AttributeAuthorityDescriptor.php
have the airs/ep issue too. I think that's it though.

Original comment by squ...@gmail.com on 11 Oct 2013 at 7:09

[GoogleCodeExporter]

Solved in r3285, as per issue 580.

Original comment by jaim...@gmail.com on 30 Oct 2013 at 10:31

• Changed state: Fixed