search

vivekrajenderan / simplesamlphp

Automatically exported from code.google.com/p/simplesamlphp
Other
0 stars 0 forks source link

AttributeAddFromLDAP erroneously checks for presence of username attribute #606

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The process function of the AttributeAddFromLDAP filter erroneously checks for 
the presence of a username attribute in the list of attributes and if missing, 
errors.

This attribute may not always be present, for example when it has already been 
mapped to something other than 'uid'. The rest of the process function does 
nothing with this username information at all, therefore the check is just a 
burden and there is no easy way around it.

Attached patch just drops the check.

Original issue reported on code.google.com by thijs@kinkhorst.com on 10 Dec 2013 at 8:59

Attachments:

GoogleCodeExporter commented 9 years ago 
Fixed in r3316. Thanks again Thijs!

Original comment by jaim...@gmail.com on 6 Jan 2014 at 5:27