search

vivekratnavel / omniboard

Web-based dashboard for Sacred
MIT License
544 stars 46 forks source link

Omniboard 2.2.0 does not display run comments #152

Closed alpapado closed 4 years ago

alpapado commented 5 years ago

Upon upgrade to version 2.2 (from a version below v2), omniboard no longer displays sacred comments added via the -c flag, in the notes column. This is also happening for previous experiments, whose comments were being displayed properly prior to the upgrade.

vivekratnavel commented 5 years ago

@alpapado Thanks for filing this issue! Omniboard v2.0 underwent major refactoring in the code and moved all the computations to server side. I will track this as a feature request to combine and display comments in the "Notes" column.

alpapado commented 4 years ago

Hi. Any news on that front?

I tried looking at the code but I am not familiar with js. Shouldn't the following lines (411-420) in src/components/RunsTable/runsTable.js do the job?

      // Add notes from comment if none has been saved in omniboard
        if (!('notes' in data)) {
            if ('meta' in data) {
              const {meta} = data;
              delete data.meta;
              if ('comment' in meta) {
                const {comment} = meta;
                data = {...data, notes: comment};
              }
            }
          }
vivekratnavel commented 4 years ago

Hi @alpapado,

This piece of code is supposed to display meta.comment in Runs collection as Notes in the UI.

Can you check your MongoDB collection to see if you have meta.comment populated in the Runs collection?

alpapado commented 4 years ago

Yes meta.comment is populated in the mongoDB as seen in mongo compass:

sacred

Yet, the notes field in omniboard does not show the comment.

It it possible that something changed in the collection structure from the part of sacred and because of that omniboard now looks for the wrong field?

vivekratnavel commented 4 years ago

Hi @alpapado,

Omniboard looks for meta.comment and I see that your MongoDB has the comment stored in meta.options.--comment. Can you post the complete meta object?

alpapado commented 4 years ago

Sure. There you go.

sacred

My bad about before. It seems there is also an external comment field i.e. meta.comment. So the code should, in theory, work I guess?

vivekratnavel commented 4 years ago

Thanks for this! I will dig deeper and debug on this issue.

vivekratnavel commented 4 years ago

Hi @alpapado, I have fixed this issue and a new version of Omniboard is on its way. Please update your Omniboard to the latest version and you should see all your existing notes in Omniboard.

Let me know if you have any issues.

vivekratnavel commented 4 years ago

:tada: This issue has been resolved in version 2.4.4 :tada:

The release is available on:

Your semantic-release bot :package::rocket: