Closed alpapado closed 4 years ago
@alpapado Thanks for filing this issue! Omniboard v2.0 underwent major refactoring in the code and moved all the computations to server side. I will track this as a feature request to combine and display comments in the "Notes" column.
Hi. Any news on that front?
I tried looking at the code but I am not familiar with js. Shouldn't the following lines (411-420) in src/components/RunsTable/runsTable.js do the job?
// Add notes from comment if none has been saved in omniboard
if (!('notes' in data)) {
if ('meta' in data) {
const {meta} = data;
delete data.meta;
if ('comment' in meta) {
const {comment} = meta;
data = {...data, notes: comment};
}
}
}
Hi @alpapado,
This piece of code is supposed to display meta.comment
in Runs collection as Notes
in the UI.
Can you check your MongoDB collection to see if you have meta.comment
populated in the Runs collection?
Yes meta.comment is populated in the mongoDB as seen in mongo compass:
Yet, the notes field in omniboard does not show the comment.
It it possible that something changed in the collection structure from the part of sacred and because of that omniboard now looks for the wrong field?
Hi @alpapado,
Omniboard looks for meta.comment
and I see that your MongoDB has the comment stored in meta.options.--comment
. Can you post the complete meta
object?
Sure. There you go.
My bad about before. It seems there is also an external comment field i.e. meta.comment. So the code should, in theory, work I guess?
Thanks for this! I will dig deeper and debug on this issue.
Hi @alpapado, I have fixed this issue and a new version of Omniboard is on its way. Please update your Omniboard to the latest version and you should see all your existing notes in Omniboard.
Let me know if you have any issues.
:tada: This issue has been resolved in version 2.4.4 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Upon upgrade to version 2.2 (from a version below v2), omniboard no longer displays sacred comments added via the -c flag, in the notes column. This is also happening for previous experiments, whose comments were being displayed properly prior to the upgrade.