search

vivekratnavel / omniboard

Web-based dashboard for Sacred
MIT License
548 stars 46 forks source link

Feature Request: Average the last n metrics #256

Closed kkoutini closed 3 years ago

kkoutini commented 3 years ago

In my case, the testing metric is a bit noisy, therefore having a metrics column with "last" extrema is not reliable. I think having the option to average the last n values of a metric can be useful.

kkoutini commented 3 years ago

I made an example for averaging the last 10 values here, is there any recommendations to allow the user to specify how many values to average. is there a good place for this? like a setting or env variable?

vivekratnavel commented 3 years ago

Hi @kkoutini,

Thanks for the request and example. I think you are almost there. We can show a small text box to get "n" as input from the user. This text box should be visible only when "last_n_avg" extrema is selected from the extrema dropdown. We can then pass that "n" to the backend to update the query accordingly.

kkoutini commented 3 years ago

Hi, thanks for the response. I've added a new column and the text box here. I had to do some changes to the UI, in order to fit the new text box (changing col-xs-4 to col-xs-3). I'm also not sure about the naming Last N. image

vivekratnavel commented 3 years ago

@kkoutini It looks good to me. We can label the extrema as "last N average". I am fine with "Last N" for the input field. Can you please raise a pull request?

vivekratnavel commented 3 years ago

Merged via #258

vivekratnavel commented 3 years ago

https://github.com/vivekratnavel/omniboard/pull/258#issuecomment-825854694