search

viveksuyampu / mobile-bookmark-bubble

Automatically exported from code.google.com/p/mobile-bookmark-bubble
Apache License 2.0
0 stars 0 forks source link

not working with google closure compiler #26

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
It would be nice if this library would be compatible with google's own closure 
compiler.

When trying to use advanced compilation closure spits the following error:

JSC_TYPE_MISMATCH: assignment to property boundScrollHandler_ of 
google.bookmarkbubble.Bubble found : (Function|null) required: function (): ? 
at line 65 character 0
this.boundScrollHandler_ = google.bind(this.setPosition, this);
^
JSC_INEXISTENT_PROPERTY: Property standalone never defined on 
Window.prototype.navigator at line 369 character 9
return !!window.navigator.standalone;

More over, since the library doesn't declare anything as external by default, 
the whole code will be optimized away (assuming those warnings are removed).

Original issue reported on code.google.com by acorn...@gmail.com on 4 Mar 2012 at 12:49