vivid-money / elmslie

Kotlin TEA/ELM implementation with first class android support
https://github.com/vivid-money/elmslie
Apache License 2.0
116 stars 13 forks source link

Fix Effects Coordination #124

Closed sergei-lapin closed 2 years ago

sergei-lapin commented 2 years ago

The issue can be described as "Parent effects are getting lost before they are observed by ElmScreen".
This was happening because of the encapsulated behavior of EffectsBuffer to stop buffering upon first subscription. But the first subscription was done by the store coordination thus effects were lost. This PR is to fix it.