vivienne / homebridge-haiku-senseme

Apache License 2.0
5 stars 0 forks source link

Verified Plugin #2

Closed dsully closed 3 years ago

dsully commented 3 years ago

This plugin should be verified via https://github.com/homebridge/verified - everything looks to be in order!

DJay-X commented 3 years ago

Hey there. Thanks for you work @vivienne @dsully Am I right that this plugin can replace https://github.com/sean9keenan/homebridge-bigAssFans ? And what are the differences/advantages to do so?

Thanks again.

vivienne commented 3 years ago

Hey there. Thanks for you work @vivienne @dsully Am I right that this plugin can replace https://github.com/sean9keenan/homebridge-bigAssFans ? And what are the differences/advantages to do so?

Thanks again.

@DJay-X I think it can be used to replace the homebridge-bigAssFans plugin, but haven't tested it myself. I wrote this plugin because I have only the Haiku lights and not their fan, and because the discovery function in the other plugin just didn't work for me when I tried it.

The main difference is the API that this plugin is built on - I used a modified version of the haiku-senseme API. It also creates a different Accessory based on the type of device identified (a light, or a fan). Lastly, when I was trying to find a plugin for my Haiku lights that would work, it seemed that all of the packages had not been updated for a while. - which may be why the plugins wouldn't work for me. This plugin was built with updated dependencies.

IMO if the other plugin is working solidly for you, there's no reason to switch over. But if you want to give this one a try and contribute or provide feedback that would be nice too. After using it in my own home for several weeks I've found that sometimes the devices become unresponsive but haven't spent much time looking into it yet.

DJay-X commented 3 years ago

Thanks for your fast reply. And also den Background Information. If I know you will help and keep development ongoing in case of problems, it sounds all good to me. 😄 I will give it try in the next weeks and point other people to this your plugin that I know are also using a BAF Haiku.

Thanks again, take care, talk soon. 👍

dsully commented 3 years ago

From my point of view, this is a much more modern and readable plugin due to how the code is written in the haiku-senseme package, as an observable and being data-driven for constructing the objects (via commands.json).

For the platform itself, the benefits of TypeScript and being based off the homebridge-plugin-template once again makes it easier to make changes and to understand the logic compared to the other plugin.

It also appears that Sean has abandoned his repo, which doesn't help either.

vivienne commented 3 years ago

This plugin should be verified via https://github.com/homebridge/verified - everything looks to be in order!

Thanks Dan for the push.. I've opened an issue to get the plugin verified.

DJay-X commented 3 years ago

Hi Folks.. Unfortunately the plugin didn't work for me. I removed "the old" BAF in config.json and added yours by config-ui-ix.

{
            "name": "Deckenventilator",
            "platform": "haiku"
        }

After homebridge restart no Fan is showing up at all. I hope you are able to fix this. Would love to switch to your plugin. Thanks in advance.

2017 Product Code K3127-S0-PW-09-02-C-01 Product Name Haiku Ceiling Fan, I Series, 52 Inches, Low Profile Mount, No Light White Airfoils, White Motor, (<125W), ( CZ, GER, IT ), (U), 0.019HP, 100-125, 200-240 VAC, Single Phase

Napkin 07 10 20, 9 53 05 AM

[2020-10-7 9:45:50] [Deckenventilator] Found a device: Ventilator / FAN,HAIKU,HSERIES / 192.168.178.32 / 20:F8:5E:F6:C0:82
[2020-10-7 9:45:50] [Deckenventilator] Not sure what to do with this device type: Ventilator (FAN,HAIKU,HSERIES)
: SenseME discovery server shutting down
dsully commented 3 years ago

@DJay-X Can you create a separate issue for that problem? Thanks

vivienne commented 3 years ago

The plugin is now verified, closing this issue.