search

vivin / gradle-semantic-build-versioning

Gradle plugin to generate version-numbers and tags using semantic versioning
MIT License
86 stars 32 forks source link

Submodule versions are always set to snapshot #103

Open esocode opened 6 years ago

esocode commented 6 years ago

I just noticed another problem related to submodules. In a project where the parent and all submodules are up-to-date and the heads are tagged with the current versions all submodules still get a snapshot version. The parent version is correct will be the submodule version if the submodule is checked out as a standalone project.

vivin commented 5 years ago

@esocode Sorry for the late response. I think this is still related to the other issue. I'm sorry I haven't had a chance to look at this stuff. A lot of this is still dependent on JGit and so if they have fixed the issue, then it shouldn't be too much work.

I will just need to have the plugin ignore submodule directories when looking for changes.

vivin commented 5 years ago

@esocode JGit 5.2.0 should be out on December 19th, and it includes a fix for the submodule issue. Hopefully that should fix the majority of your problems.

esocode commented 5 years ago

Any news about this?

vivin commented 5 years ago

Sorry. Not yet. I will try and upgrade to a new version of jgit and see if that helps it. I have been really busy with my PhD and haven't been able to devote time to this.

esocode commented 5 years ago

No problem, take your time. It's not mission critical. And if the next version comes from a doctor it may be even better ;-)