search

vivin / gradle-semantic-build-versioning

Gradle plugin to generate version-numbers and tags using semantic versioning
MIT License
85 stars 32 forks source link

allow promotion to release without code changes -- fixes #108 #111

Open JoshMcCullough opened 4 years ago

JoshMcCullough commented 4 years ago

Proposed fix for #108. Needs review.

Note -- excluded 4 tests (which otherwise would now fail) from VersionUtils I think it is correct but should be verified as well! Also note that there were 480 failing tests before this change which are still failing.

vivin commented 4 years ago

There were 480 failing tests before?! That's quite strange. Will have to take a look.

vivin commented 4 years ago

@JoshMcCullough what version of gradle are you using?

The project was using a really old version and I'm noticing intermittent failures after I upgraded to Gradle 6 (had to update some config too).

JoshMcCullough commented 4 years ago

I'll take a look at this tomorrow.

frankyfish commented 3 years ago

Sorry for sneaking in but are there any news or hope to have this pull merged? Would be a really nice feature to have.

JoshMcCullough commented 3 years ago

Oops, looks like I said I'd look into something then never did. But I agree, I'd love to have this merged in.

JoshMcCullough commented 3 years ago

I started looking at this this weekend but I can barely get the tests to run. A lot are failing (as mentioned, but my number was off originally). I'm not familiar with Spock (I use Mockito) so I'm not sure how to fix things w/out investing a lot of time.

JoshMcCullough commented 2 years ago

Ran into this again just now. :(