search

vivin / gradle-semantic-build-versioning

Gradle plugin to generate version-numbers and tags using semantic versioning
MIT License
85 stars 32 forks source link

Spock changes and shield style for CircleCI badge #98

Closed Vampire closed 6 years ago

Vampire commented 6 years ago
vivin commented 6 years ago

@Vampire hey! Sorry; just seeing this now. I was pretty much on vacation from middle of May until around July 2nd after which I started a new job, so I wasn't looking at this stuff.

Vampire commented 6 years ago

Don't worry.

  1. it is just a fix for the tests that does not fail in this case, but I reworked it a bit when contributing this methodology to Gradle itself and thereby found some minor issues I thought I PR here too.
  2. Long ago I remembered why I don't like the approach you take with this plugin and don't use it anyway. :-)
vivin commented 6 years ago

Ok -- I will be making some changes soon to deal with a new version of JGit and maybe include some small enhancements to deal with submodules. So I will merge this stuff in before that.

BTW, what is it that you didn't like with the approach? I will try to improve it if I can. :)

Vampire commented 6 years ago

Unlikely, it is the whole concept. I don't like having access to the VCS being necessary to build the software. It is ok to query some information from the VCS, storing it in some file e. g., but it shouldn't fail if VCS is not available. If you e. g. export the sources, you suddenly cannot build it anymore. Or if you use e. g. HanDouts and its server-side checkout feature, the build agent also has no access to the VCS.

vivin commented 6 years ago

Well, I built this largely to work with versioning with VCS, so that was a core assumption. So yes; it's unlikely that I will change this.

Vampire commented 6 years ago

I know, that's why I didn't ask for it. :smile: