vivinano / MudaeAutoBot

python bot that uses strictly the **Discord API** to Roll,Claim,and Kakera Snipe in Mudae. 5/10/21 project converted over to discum library
Apache License 2.0
152 stars 49 forks source link

Claiming all Wishes #94

Closed banana-vacuum closed 3 years ago

banana-vacuum commented 3 years ago

How would i be able to claim, only with the kakera limit being used? When someone else wishes a character, the bot doesnt claim, even though that character is over the "min_kak" limit. Would there be a way for the bot to solely work on the kakera and the name list to avoid that issue?

vivinano commented 3 years ago

The bot doesn’t claim because usually when someone else wishes a character they would claim said character. As per the snipe protection check what is the roll sniping setting in your channel data again ?

Sent from my iPhone

On Aug 25, 2021, at 7:37 AM, banana @.***> wrote:

 How would i be able to claim, only with the kakera limit being used? When someone else wishes a character, the bot doesnt claim, even though that character is over the "min_kak" limit. Would there be a way for the bot to solely work on the kakera and the name list to avoid that issue?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

vivinano commented 3 years ago

And the bot claims using all 3

in the priority of

Wishes > Character > series > kakera (If Kakera Value can be determined)

if a character say

Bob is wished and in my char and series list

it will basically run code of trying to add a emoji 3 times

The "safety" mechanic that is added which I think you bring up is that if Someone Else rolls and claims a character then the BOT will see that this character has already been claim before it can make an attempt so its Skips the attempt because there would be no purpose to add an emoji on a character Mudae has already given to Someone Else

banana-vacuum commented 3 years ago

Sniping is set to "0". Ive had this issue persistently, I have the "min_kak" set to 300, and due to the .5 sleep that was added, the bot never claims in time, and the bot freezes no matter if no one claimed the wished character, ill wait 3 seconds and it still wasn't claimed, and in those 3 seconds testing, someone else claimed the character. Ive noticed the "if m['content'].startswith('<@' + user['id'] + '>') or m['content'].startswith('<@!' + user['id'] + '>')" Line and was wondering if that is the reason it doesnt claim others wishes no matter the kakera amount, would there be a way to do a search only for the "@" and "Wished" in the "Content" so it could claim no matter if someone wished the character, because it seems the bot will only claim if only the user's id is in the "content". Thanks.

vivinano commented 3 years ago

If it’s kakera sniping then it will snipe but it would have to be over that set amount as for sniping other wishes you can change it as you please

But as for me pushing that change to main I will not be doing so

Because 1)” wished” is not universal across languages 2) “@“ is not really super accurate as you then will react to anything that is @ IE @everyone , @rollers

So the persistent issue is that this feature was never implemented

If a wished character by others that had 301+ kakera then the bot will snipe it solely based on the character having 301+ kakera but

Kakera calculation are based on like rank , claim rank , or kakera crystal emoji if it doesn’t find any of that then kakera values cannot be determined and also will not snipe

Sent from my iPhone

On Aug 25, 2021, at 6:49 PM, banana @.***> wrote:

 Sniping is set to "0". Ive had this issue persistently, I have the "min_kak" set to 300, and due to the .5 sleep that was added, the bot never claims in time, and the bot freezes no matter if no one claimed the wished character, ill wait 3 seconds and it still wasn't claimed, and in those 3 seconds testing, someone else claimed the character. Ive noticed the "if m['content'].startswith('<@' + user['id'] + '>') or m['content'].startswith('<@!' + user['id'] + '>')" Line and was wondering if that is the reason it doesnt claim others wishes no matter the kakera amount, would there be a way to do a search only for the "@" and "Wished" in the "Content" so it could claim no matter if someone wished the character, because it seems the bot will only claim if only the user's id is in the "content". Thanks.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

banana-vacuum commented 3 years ago

So the bot originally is able to claim others wishes? And if that was possible what line of code allows that? Thank you for always helping.

vivinano commented 3 years ago

No the bot was never made to claim others wishes only your own wishes

There would be a way to claim wishes but you have to make those changes on your own you literally already have located the area of code to determine wished sniping so modify that area but since again this is a self enhancement and not a issue as the bot NEVER sniped other wishes

Sent from my iPhone

On Aug 25, 2021, at 7:37 PM, banana @.***> wrote:

 So the bot originally is able to claim others wishes? And if that was possible what line of code allows that? Thank you for always helping.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

banana-vacuum commented 3 years ago

I understand bro, i was coming here for help for a selfish question, this is, yes, something that maybe only i would benefit from, if i did have money i would pay to have it done but am not in a position to do so, I myself can understand basic code, but can not write it, i was looking up to you for help regarding this matter. Whether you help me or not is entirely up to you, and again, i thank you for your hard work, and always being there to help others problems.

vivinano commented 3 years ago

It’s fine I didn’t mean to sound rude or anything I don’t mind helping. But if I start making code revision for each user then I will than have to keep track of every user version of the code and then the possible bugs that come with those versions and then it becomes a job and no longer a side project for fun.

Sent from my iPhone

On Aug 25, 2021, at 8:09 PM, banana @.***> wrote:

 I understand bro, i was coming here for help for a selfish question, this is, yes, something that maybe only i would benefit from, if i did have money i would pay to have it done but am not in a position to do so, I myself can understand basic code, but can not write it, i was looking up to you for help regarding this matter. Weather you help me or not is entirely up to you, and again, i thank you for your hard work, and always being there to help others problems.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

banana-vacuum commented 3 years ago

I completely understand, if i did have knowledge in python i would happily do it myself and possibly help you with any upcoming bugs, I dont know if doing the change is do-able in your perspective, i, again would understand if you didnt want to, and if the possibility did occur that you did make a revision, I wouldn't mind being a bug tester. Again, sorry for the inconvenience.

vivinano commented 3 years ago

Do-able is not the issue I can do it as before I uploaded the code my earliest “personal” version sniped all wishes. (Server was mad)

But I have users who don’t want to even snipe kakeraP so this change would mean I eventually have to change back the to the original state

It’s overall not a I need bug testers it’s that not all user wants certain features. So making that change only maybe like 5 ppl would use out of the rest means slower performance for more checks. More grievances from users who are angry that they sniped a wish that someone else wanted and not their personal.

So overall this would have to be a personal version coded for your personal needs. I have no objection for you to make personal edits to the code to fit yours needs. I have made the code very easy to modify as it only uses the standard python library and the only 3rd party library would be for discord interactions.

Sent from my iPhone

On Aug 25, 2021, at 8:29 PM, banana @.***> wrote:

 I completely understand, if i did have knowledge in python i would happily do it myself and possibly help you with any upcoming bugs, I dont know if doing the change is do-able in your perspective, i, again would understand if you didnt want to, and if the possibility did occur that you did make a revision, I wouldn't mind being a bug tester. Again, sorry for the inconvenience.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

banana-vacuum commented 3 years ago

Thank you, as I have stated previously, I do not know how to code, and any assistance would be greatly appreciated, even if little, unless your "personal" version would work?

vivinano commented 3 years ago

My personal version was modified to what you have currently as this was built from that version for the general public.

I don’t mind providing assistance I have already confirmed with you that the area you pointed out was the area that wish sniping code resides. You have already given suggestions on how to change the code and I have also replied with various issues that might come with your suggestions

But if your it’s your personal version those issues become a null point correct ?

Not sure what more assistance would you request of me as it seems now you are technically requesting that I write the code for you. Keep in mind that you this repo is already pretty generous as I have already invested several hours into the creation of this bot twice from the ground up as the original version was deprecated due to a dependency update along with various moments to make sure there are no issues that arise.

Sent from my iPhone

On Aug 25, 2021, at 9:05 PM, banana @.***> wrote:

 Thank you, as I have stated previously, I do not know how to code, and any assistance would be greatly appreciated, even if little, unless your "personal" version would work?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

banana-vacuum commented 3 years ago

I am sorry again for asking a selfish question, i will take that as a no, but thanks again for always being there when issues arise, my only clue to doing this is to just remove the code that detects a wish all in general, so it only focuses on the name list and min_kak.

vivinano commented 3 years ago

If you remove the wish then it will no longer snipe personal wishes so you have the depend on char list , series list or min_kak

If your problem is that it literally doesn’t snipe “your personal” wish then that is a problem I will look at if so give me a screenshot of the character failed the checks as even if the character succeeds one check then it will snipe

Sent from my iPhone

On Aug 25, 2021, at 9:39 PM, banana @.***> wrote:

 I am sorry again for asking a selfish question, i will take that as a no, but thanks again for always being there when issues arise, my only clue to doing this is to just remove the code that detects a wish all in general, so it only focuses on the name list and min_kak.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.