search

vivjay30 / Cone-of-Silence

The Cone of Silence:
MIT License
151 stars 22 forks source link

[bug] Duplicate un-normalize in train.py #13

Closed SouppuoS closed 2 years ago

SouppuoS commented 3 years ago

Hi, vivjay

https://github.com/vivjay30/Cone-of-Silence/blob/a3f27eb021f579b4543911c87f681a30004959b3/cos/training/train.py#L115-L124 line 117 and line 121 are the same. Un-normalize twice will make the test loss (validation) do not decrease. much like the problem @zhangshengoo asked this https://github.com/vivjay30/Cone-of-Silence/issues/12#issuecomment-836093703

vivjay30 commented 2 years ago

Thanks for pointing this out! I'll go ahead and fix this