vivo-community / scholars-discovery

BSD 3-Clause "New" or "Revised" License
2 stars 6 forks source link

#211: add generic facet limit and set to unlimited #212

Closed nymbyl closed 4 years ago

nymbyl commented 4 years ago

NOTE: field level limits are ignored when exclusionTag is used (from GraphQL endpoint)

The problem is SOLR set limits on facets like f.<field-name>.facet.limit=# - but when an exclusionTag is added ("{!ex=tag}") to the field name, the FieldWithFacetParameter sends that along as part of the limit command (f.{!ex%3Dtag}<field-name>.facet.limit=#)- and SOLR looks to be ignoring it, so it falls back to the higher level default (which is 10). So the effect is adding an exclusionTag limits facets to 10.

This just sets the limit to unlimited (-1). I tried Integer.MAX_VALUE, but got JVM Error Array too big. This change does still honor "pageSize" as a parameter (so it can be limited that way).