vivo-project / VIVO

VIVO is an extensible semantic web application for research discovery and showcasing scholarly work
http://vivoweb.org
BSD 3-Clause "New" or "Revised" License
207 stars 130 forks source link

VIVO-1686: GroupedPropertyList should be parallel #3276

Closed chenejac closed 1 year ago

chenejac commented 5 years ago

alessandro galasso (Migrated from VIVO-1686) said:

The method   getPropertyList of class  BaseIndividualTemplateModel is too slow if it works with an external   rdf database.  Http client have to open end close too many connections in series.

we are using GroupedPropertyList parallel version to

match blazegraph performance requirements (Parallel client processing):  https://wiki.blazegraph.com/wiki/index.php/PerformanceOptimization

the performance inprovment is about 50% of processing time.

could be useful to merge in the community version

 

 

chenejac commented 5 years ago

alessandro galasso said:

I created a pull request about this , https://github.com/vivo-project/Vitro/pull/116

 

chenejac commented 5 years ago

Andrew Woods said:

Please put this JIRA back into "Start Review" once the code review comments have been addressed.

chenejac commented 5 years ago

alessandro galasso said:

i have enforced duraspace-checkstyle.xml as requested, the parallel version is working fine as i can see with blazegraph triplestore.

chenejac commented 5 years ago

alessandro galasso said:

new PR:  https://github.com/vivo-project/Vitro/pull/120

 

chenejac commented 5 years ago

Andrew Woods said:

Pending additional testing from @grahamtriggs.

chenejac commented 5 years ago

Andrew Woods said:

It appears that comments have been resolved. Do you agree @grahamtriggs?