search

vivo-project / VIVO

VIVO is an extensible semantic web application for research discovery and showcasing scholarly work
http://vivoweb.org
BSD 3-Clause "New" or "Revised" License
202 stars 127 forks source link

VIVO-1970: Remove rootTab resources from application metadata model #3556

Open chenejac opened 3 years ago

chenejac commented 3 years ago

Brian Lowe (Migrated from VIVO-1970) said:

The rootTab resources in the applicationMetadata model no longer appear to be used for anything, but triples are still loaded for them from firsttime data.  In the past this was innocuous, but now it adds unncessary complexity to the update of "firsttime" data on restart.

The main issues looks to stem from the fact that while the blank node for the Portal resource is correctly renamed to a URI resource using VIVO's default namespace, the root tab resource connected to it is not.  This leaves a number of triples with blank nodes that cause the isIsomorphicWith() test to fail (even though it should be a true isomorphism test that treats blank nodes as variables). 

It seems like the best thing to do would be to remove these triples entirely from the firsttime RDF files.

brianjlowe commented 2 years ago

Updated title and description to reflect current status. Portal is still used, but is named correctly in the default namespace so that it can be diffed. rootTab is useless, and the firsttime code has to specifically exclude it.