search

vivo-project / VIVO

VIVO is an extensible semantic web application for research discovery and showcasing scholarly work
http://vivoweb.org
BSD 3-Clause "New" or "Revised" License
206 stars 129 forks source link

Reconciliation API needs to deliver boolean values for "match" #3741

Closed hauschke closed 2 years ago

hauschke commented 2 years ago

Describe the bug According to https://reconciliation-api.github.io/specs/latest/ a match in the reconciliation API is described as "A boolean matching decision, which indicates whether the service considers this candidate good enough to be chosen as a correct match."

To Reproduce Steps to reproduce the behavior:

  1. Go to https://reconciliation-api.github.io/testbench/#/client/
  2. Enter the URL of a VIVO reconciliation API, for example https://reconciliation-api.github.io/testbench/#/client/https%3A%2F%2Fvivo.tib.eu%2Ffis%2Freconcile
  3. Enter "Hannover" in name, click on reconcile.
  4. See the error message.

Expected behavior Replace "match": "false" with "match": false,

Screenshots grafik

Environment (please complete the following information):

chenejac commented 2 years ago

Resolved with https://github.com/vivo-project/Vitro/pull/325