I18n redesign

[chenejac]

VIVO GitHub issue: i18n redesign project board

Vitro PR

• Other Relevant Links (Mailing list discussion, related pull requests, etc.)
  • https://wiki.lyrasis.org/display/VIVO/Sprint+-+i18n+redesigning
  • https://wiki.lyrasis.org/display/VIVO/Sprint+-+i18n+redesigning+2

What does this pull request do?

Moving UI labels from property files to rdfs Removing language specific template files Merging VIVO-languages and Vitro-languages repositories into VIVO and Vitro repositories Support for institution specific translations (private language subtags)

What's new?

.property UI label files are migrated to .ttl files i18n module is extended to support loading of UI labels from ttl files and property files ftl files from VIVO-language have been moved to VIVO repository (universal language constructions working for all languages has been used) home artifacts and UI label files from VIVO-languages have been moved to VIVO pom files have been adopted *.yml files (build) have been adopted

How should this be tested?

• checkout Vitro i18n-redesign branch
• Install VIVO
• Add into runtime properties

  RDFService.languageFilter = true
  languages.selectableLocales = en_US, de_DE, sr_Latn_RS, ru_RU, fr_CA, en_CA, es, pt_BR, fr_CA_x_uqam

• configure email settings
• copy sample sample-data-i18n.ttl sample-data-i18n-de_DE.ttl sample-data-i18n-en_CA.ttl sample-data-i18n-en_US.ttl sample-data-i18n-fr_CA.ttl sample-data-i18n-fr_FR.ttl from https://github.com/vivo-project/sample-data/tree/main/i18n into $VIVO_HOME/rdf/abox/filegraph
• copy fr_CA_x_uqam directory into $VIVO_HOME/rdf/i18n/ or unzip this file into $VIVO_HOME/rdf/i18n/
• Run tomcat and open VIVO in a web browser
• Login as root administrator
• https://github.com/vivo-project/Vitro/pull/332
  • Go to siteAdmin
  • Open form to create new Person
  • Verify that the form looks Ok for all languages
• https://github.com/vivo-project/Vitro/pull/333
  • Open http://locahost:8080/vivo/searchHelp
  • verify it is available in multiple languages
• https://github.com/vivo-project/VIVO/pull/3777
  • Open a person profile page
  • Click on qr code image, larger image will pop up, click on large image to get to Export qr code page.
  • Click on the link "What is this?"
  • You should be on about qr codes page. Try changing locales to verify it is available in multiple languages
• https://github.com/vivo-project/VIVO/pull/3778
  • Open a researcher profile page
  • Add a journal article in the Science journal
  • Open Map of Science for a researcher (you need a researcher profile who published a paper in the journal Science) and verify it is available in multiple languages
  • Open http://locahost:8080/vivo/vis/map-of-science/about and verify it is available in multiple languages
• https://github.com/vivo-project/VIVO/pull/3780
  • Open home page, view list of research types
• https://github.com/vivo-project/VIVO/pull/3783
  • Verify the following steps are available in all languages
  • Create a person
  • Add role head of
  • Add role memeber of
  • Add advisees
  • Create publication
  • Add authors via Manage list of authors
  • Add editors via Manage list of editors
  • Open person profile, click add geographic location, click add new item of this type (leave Campus selected)
    • You should see something like Create "geographic location" entry for ...
• https://github.com/vivo-project/VIVO/pull/3791
  • Open http://locahost:8080/vivo/vis/publication-graph
  • Verify that search text is translated
  • Verify that Records X - Y of Z is translated
• https://github.com/vivo-project/VIVO/pull/3795
  • Create person profile
  • Add website link, switch language, edit link label
  • Verify that only one label is shown on profile's page.
• https://github.com/vivo-project/Vitro/pull/334
  • For each of installed languages execute following actions:
  • Create new user, e-mail to the user about created account should be received.
  • Use the link from the e-mail, set user password, you should receive e-mail after password is set.
  • Try reset user's password, e-mail to the user about created account should be received.
  • Try to log in as a user and change e-mail address, you should receive e-mail about that.
  • Break your page-home.ftl and open home page, you should see "There was an error in the system. This error has been reported to the site administrator. " Check email in administrator's mailbox
• https://github.com/vivo-project/Vitro/pull/335
  • Open http://localhost:8080/vivo/termsOfUse
  • Verify placeholder is available in all languages (change UI language)
• https://github.com/vivo-project/Vitro/pull/353
  • Open http://localhost:8080/vivo/events
  • Switch UI to the Spain language
  • In the list of Events there shouldn't be any in German language (only in English or Spain language).
• https://github.com/vivo-project/VIVO/pull/3802
  • Change language to the last one in the list (France (Canada) - UQAM)
  • At the home page you should found the label "Recherche uqam"
  • If you login, you will also notice that logout option in the menu has been changed to "Déconnexion wilma uqam" when the last language has been selected
  • Also, on some pages labels with uqam suffix will appear.
• https://github.com/vivo-project/Vitro/pull/356
  • Open a researcher profile page
  • Click on uploading the image
  • Change language to French
  • Check labels Taille maximale de l'image: 6 mégaoctets, Taille minimale de l'image: 200 par 200 pixels, before this PR it was Taille maximale de limage: {0} mégaoctets and Taille minimale de limage: {0} par {1} pixels
• https://github.com/vivo-project/Vitro/pull/352
  • Create data property with range rdfs:Literal
    • Create faux data property (not error should appear on creation of faux data property)
    • Create data and object faux properties, add values. Test that faux properties are available even if domain of base property doesn't match individual types, but domain of faux property match individual type.
  • Faux data property creation should be available from data property page
  • Both types of faux properties listings should work.
  • Faux data properties range should always be the same as base property.
  • Faux data and object property ranges should be constrained by not disjoint properties.
  • Set faux object property and faux data property ranks
  • Verify that ranks are visible in verbose edit mode, verify that ranks are applied on property sorting

Example:

• Does this change require documentation to be updated? Yes, this wiki page will describe adding new UI language - https://wiki.lyrasis.org/display/VIVODOC114x/Internationalization
• Does this change add any new dependencies? No
• Does this change require any other modifications to be made to the repository? VIVO-languages repository is not needed any more, the PR also includes changes in the workflows (build GitHub action).
• Could this change impact execution of existing code? No
• Large pull requests should be avoided. If this PR is large (more than 1,000 lines of codes), please provide short explanation why your contribution can't be decoupled in smaller PRs. This is the result of two sprints

Interested parties

Tag (@ mention) interested parties or, if unsure, @VIVO-project/vivo-committers

[ghost]

• [x] https://github.com/vivo-project/Vitro/pull/332
• [x] https://github.com/vivo-project/Vitro/pull/333
• [x] https://github.com/vivo-project/VIVO/pull/3777

Some languages has undesired word wrapping.

• [x] https://github.com/vivo-project/VIVO/pull/3778

Can't find Journal of Science in sample data.

What context is there does render in all available languages.

• [x] https://github.com/vivo-project/VIVO/pull/3780

French languages missing ellipses if they are intended to use. Also, the bottom horizontal line is not bottom padded as much as the other like sections.

• [x] https://github.com/vivo-project/VIVO/pull/3783

When adding advisee typeahead selection of existing individual not working as expected.

Otherwise, worked as final line item stated.

• [x] https://github.com/vivo-project/VIVO/pull/3791

Padding is cramped. Worse in some languages. But all have no space right of the search label.

Also, both French Canadian is showing blank page.

• [x] https://github.com/vivo-project/VIVO/pull/3795
• [x] https://github.com/vivo-project/Vitro/pull/334

Russian locale (ru_RU) is missing create password link in email template.

• [x] https://github.com/vivo-project/Vitro/pull/335
• [x] https://github.com/vivo-project/Vitro/pull/353

• [x] https://github.com/vivo-project/VIVO/pull/3802

Unable to find matches to labels suffixed with uqam. Possibly, the setup process is incomplete. See https://github.com/TAMULib/VIVO/blob/i18n-redesign-docker/start.sh#L39 in attempts to automate setup instructions.

• [x] https://github.com/vivo-project/Vitro/pull/356

• [ ] https://github.com/vivo-project/Vitro/pull/352

Range type selected was XML literal and it failed to create faux data property.

Does allow create faux data property for range type string.

[chenejac]

• [x] [3800 i18n redesign] Supporting private tags #3802

Unable to find matches to labels suffixed with uqam. Possibly, the setup process is incomplete. See https://github.com/TAMULib/VIVO/blob/i18n-redesign-docker/start.sh#L39 in attempts to automate setup instructions.

Yes, I think automate setup is not configured well for the example of uqam UI labels localization. It is not in sample-data repository, it can be only downloaded from this link at the moment - https://github.com/vivo-project/Vitro/files/10185798/fr_CA_x_uqam.zip. So, the changes are not in sample data, the changes are in labels translations.

[ghost]

@chenejac I followed step

• Unzip this file into $VIVO_HOME/rdf/i18n/

As can be seen here

https://github.com/TAMULib/VIVO/blob/i18n-redesign-docker/start.sh#L43

from

https://github.com/wwelling/sample-data/tree/main/fr_CA_x_uqam

It looks as I need to only copy a directory within the zip file.

https://github.com/wwelling/sample-data/tree/main/fr_CA_x_uqam/interface-i18n/firsttime into $VIVO_HOME/rdf/i18n/

I will give this a try.

[ghost]

@chenejac this looks to be what is needed

cp -r sample-data/fr_CA_x_uqam /usr/local/vivo/home/rdf/i18n/fr_CA_x_uqam

currently redeploying now and will test

• [x] https://github.com/vivo-project/VIVO/pull/3802

This works as expected with putting sample data in correct place.

• [ ] https://github.com/vivo-project/Vitro/pull/352

@litvinovg I am still receiving this error page when trying to create a faux property from an XML literal.

The image is and was using the latest from upstream i18n-redesign. See https://github.com/TAMULib/VIVO/blob/i18n-redesign-docker/Dockerfile#L30

Here is the screen before the error page.

leaving only this test remaining

• [x] https://github.com/vivo-project/Vitro/pull/334

[ghost]

labs.library.tamu.edu/:264 Uncaught SyntaxError: Unexpected identifier 'Université'

?uri=http%3A%2F%2Flocalhost%3A8080%2Fvivo_i18n%2Findividual%2Fn6810:324 Uncaught ReferenceError: subOrganizationPublicationTemporalGraphCommonURL is not defined at ?uri=http%3A%2F%2Flocalhost%3A8080%2Fvivo_i18n%2Findividual%2Fn6810:324:30