Open michel-heon opened 1 year ago
@michel-heon why did you change version to 1.14.1-SNAPSHOT? Change of the version is usually done by a script when a new release is published.
@chenejac Because version 1.13.1-SNAPSHOT does not reflect where we are in development and it is often confusing to work on branches that do not correspond to the working version
@litvinovg The return to 1.13.1 is done.... but this version corresponds to the previous sprint and is not representative of the evolution of development. This version misalignment may lead to misunderstandings about the evolution of the development.
@litvinovg , Why do a test on an OS installation based on Java 8 when the basic specification of this issue is to use Java 11 ?
@michel-heon To model what user trying to update VIVO or Vitro to next version would experience.
@litvinovg @chenejac The files have been changed as discussed
I don't remember discussion about maven enforcer. I think increasing version of maven enforcer and enforcing maven version is unnecessary.
VIVO GitHub issue 3834: (please link to issue) see also for vitro https://github.com/vivo-project/Vitro/pull/368
Migration to Java 11 from Java 8
What does this pull request do?
This PR modifies the pom files so that VIVO and Vitro are compiled and run with Java 11
What's new?
How should this be tested?
Purge the maven downloaded library directory
rm -fr ~/.m2/repository
Install Java 11
Install SOLR and Tomcat according to https://wiki.lyrasis.org/display/VIVODOC113x/Installing+VIVO
Configure
runtime.properties
andapplicationSetup.n3
Extracted VIVO and Vitro concerned by this PR
copy this
settings.xml
in./VIVO/installer
directoryset environment variables indicated in settings.xml
Check incompatibility with Java-8
Overview of the output During the execution, it is possible to follow the following trace in the maven logs
The compilation aborts because the class code is not compatible with Java version 8
Validate the VIVO/Vitro compilation with Java 11
Overview of the output During the execution, it is possible to follow the following trace in the maven logs
Testing execution in tomcat Before starting Tomcat, you can copy the samples data contained in https://github.com/vivo-project/sample-data/tree/main/i18n and copy it to $VIVO_HOME/rdf/abox/filegraph then
You can navigate VIVO in your browser http://localhost:8080/vivo
You can validate that VIVO runs in TOMCAT in a Java-11 context with the following command
Interested parties
@chenejac