search

vivo-project / VIVO

VIVO is an extensible semantic web application for research discovery and showcasing scholarly work
http://vivoweb.org
BSD 3-Clause "New" or "Revised" License
202 stars 127 forks source link

Fixed jquery selector for capability map tabs #3921

Closed milospp closed 7 months ago

milospp commented 7 months ago

What does this pull request do?

Fixes the unresponsive behavior of capability map nodes in the Nemo theme when clicked. The issue stemmed from an incorrect jQuery selector used in the theme's jQuery version.

What's new?

Resolved the jQuery selector issue by adding single quotes to the value of the href attribute: $(".titles li a[href='#" + name + "']")...

How should this be tested?

  1. Open the Capability Map tab.
  2. Search for an item.
  3. Click on a node to verify if it opens the information tab on the right side.
  4. Test this across all themes for thorough validation.

image

gneissone commented 7 months ago

I know it's not the point of this issue and PR and it's a non-trivial task, but would be great if we could upgrade the jQuery version. The version VIVO uses is from 2016 and is flagged as a security risk. https://github.com/vivo-project/VIVO/issues/3528

chenejac commented 7 months ago

I know it's not the point of this issue and PR and it's a non-trivial task, but would be great if we could upgrade the jQuery version. The version VIVO uses is from 2016 and is flagged as a security risk. #3528

Let's resolve this in the separate PR.