search

vivo-project / VIVO

VIVO is an extensible semantic web application for research discovery and showcasing scholarly work
http://vivoweb.org
BSD 3-Clause "New" or "Revised" License
202 stars 127 forks source link

Improved docker setup #3940

Closed wwelling closed 3 months ago

wwelling commented 5 months ago

VIVO GitHub issue: https://github.com/vivo-project/VIVO/issues/3939

What does this pull request do?

This PR provides more configurability for docker compose and build of the VIVO docker image. Primarily addressing port mapping configuration via .env file for docker-compose.yml variable substitution.

What's new?

  1. solr and tomcat service port mapping configurable via .env
  2. ability to specify VIVO home path within the container
  3. local mount for VIVO solr core data to persist through container restarts

How should this be tested?

This can be tested by following https://github.com/wwelling/VIVO/blob/issue-3939/README.md#docker-compose. For more exhaustive testing the .env file can be modified between container restarts for desired effect.

Interested parties

@chenejac, @isl3

isl3 commented 4 months ago

It might be helpful to some if there was a comment somewhere saying VIVO_HOST_PORT/SOLR_HOST_PORT can also specify host IP, but this should be obvious to anyone who knows how docker-compose files work so not an large concern.

litvinovg commented 4 months ago

@chenejac @ivanmrsulja Can we write down more information about what was tested and reviewed?

chenejac commented 3 months ago

@chenejac @ivanmrsulja Can we write down more information about what was tested and reviewed?

Tested by Ian Slatter, tested and reviewed by Ivan Mrsullja (linux), reviewed by Dragan Ivanovic.