search

vixalien / decibels

Play audio files
https://gitlab.gnome.org/vixalien/decibels
GNU General Public License v3.0
51 stars 17 forks source link

waveform: add whitespace #54

Closed jimmac closed 10 months ago

jimmac commented 10 months ago
jimmac commented 10 months ago

Before: Screenshot from 2024-01-11 12-00-37 After: Screenshot from 2024-01-11 12-25-58

vixalien commented 10 months ago

Hmm, I'm not sure how I feel about this. While this change looks better, I feel like adding padding makes the waveform look "disjointed" (lack of better words) as it appears and vanishes into thin air. Having the waveform border-to-border makes the waveform look as if it continues across the window edge and gives it a nice look, and communicates to the user it can be scrolled.

The current look was intentional, but I will of course merge this PR if you confirm it's really better.

On the other hand, if the layout change was to proceed, I feel like it would be a lot nicer if we added margins to the container box so that the waveform, scale and buttons are all evenly padded.