search

vixalien / muzika

Elegant music streaming app
GNU General Public License v3.0
268 stars 17 forks source link

Get rid of deep event handlers #143

Closed vixalien closed 4 months ago

vixalien commented 4 months ago

In some components we have widgets like the following scenario:

PlaylistItemView
|- PlaylistListView
   |- PlaylistItem
      |- Button (add)

the lowermost button with an "add" label will emit the signal clicked, which will get propagated upwards as add. This is bad practice, and we should instead have an action called playlist.add(videoId) which will add the track and remove the need for those signals

vixalien commented 4 months ago

Closing in favor of #146