vixalien / sticky

A simple sticky notes app for GNOME
https://flathub.org/apps/details/com.vixalien.sticky
MIT License
175 stars 27 forks source link

Add Translator Credits support #54

Closed ghost closed 1 year ago

ghost commented 1 year ago

More information: https://wiki.gnome.org/TranslationProject/DevGuidelines/Add%20translator%20credits

vixalien commented 1 year ago

please let me know if this can be merged before the 2 other PRs, and I'll do it right away!

vixalien commented 1 year ago

hey! please rebase and then resolve any confilcts

and I'd like to know does this work. does each translator add their names or??

ghost commented 1 year ago

Normally, you put this string in the about window it should read the translator informations from the po files.

In this case it seems not working. You can close the PR.

rffontenelle commented 1 year ago

and I'd like to know does this work. does each translator add their names or??

The translator should put its name/nick and, optionally, the email/website address. Then, in the Credits page, a Translated by will contain the info provided by this string.

For instance, see Nautilus/Files in pt_BR (the right-side icon is the translator's mail when provided):

Captura de tela de 2023-05-17 15-12-19

The input should be something like:

#. TRANSLATORS: eg. 'Translator Name <your.email@domain.com>' or 'Translator Name https://website.example'
#: src/src/application.ts:349
msgid "translator-credits"
msgstr ""
"Translator1 Name <their@email.com>\n"
"Translator2 Name <their2@email.com>\n"
"Translator Without Mail"
vixalien commented 1 year ago

rebase main and I'll merge this

vixalien commented 1 year ago

@rffontenelle

The input should be something like:

that goes in the .pot file right

rffontenelle commented 1 year ago

that goes in the .pot file right

Must go. The .pot file is made of strings extracted from the source code, translators-credit is no different.

I assume the pot in this PR commit was generated after adding the string to the code.

vixalien commented 1 year ago

alright. waiting for a rebase @sabriunal

and please add your name as a test so I can see if it works in the about menu

ghost commented 1 year ago

rebased and it's working.

Ekran Görüntüsü - 2023-05-24 17-58-22