search

vixen-project / vixen

ViXeN is a multimedia viewer, metadata extractor and annotator.
https://vixen.readthedocs.io
Other
15 stars 8 forks source link

JOSS review #23

Closed amoeba closed 5 years ago

amoeba commented 5 years ago

Hi @prabhuramachandran, I've just finished going through the review checklist over on https://github.com/openjournals/joss-reviews/issues/1501 and only had one item I couldn't check off:

Could you please expand the "Support" section of the README to cover this?

Otherwise, everything else looks great. I found a few typographical errors that I'll send a PR for in a sec. Let me know if you have any questions and also let me know when you want me to look at the README again.

I found the software pretty straightforward to use but had one question: In the Project view, I tried to select multiple items and couldn't. Is there a way or could this be a useful thing to add? This question isn't strictly part of the review process so you don't need to answer it or do anything about it in order to finalize the review.

amoeba commented 5 years ago

PR I mentioned above is https://github.com/vixen-project/vixen/pull/24.

prabhuramachandran commented 5 years ago

Hi Bryce,

Thanks for the kind comments and your thorough review. I will make the requested changes to the support section later today. I have merged your kind PR!

Multiple selection is a great idea and one we thought about but something I am not quite sure how best to implement. Is this just to be able to edit multiple tags? The issue is, what exactly should the UI do on a multi-selection of files, what about a directory? If there are already existing fields, multi-selecting them would allow a user to accidentally edit tags when they may not have wanted to. Also it isn't clear what the video view should do, showing multiple videos/pictures may be a bit too much? Given the difficulties in what exactly would be ideal I just decided not to implement it until there was a clear idea of what exactly we wanted to do. I hope that clarifies the reason why we don't have that feature (yet).

Anyway, thanks for the pointer to the support section needing work, I will add that later today.

Thanks again for taking the time to review ViXeN!

amoeba commented 5 years ago

Sounds like you've definitely scratched your head a bit on the multiple-selection idea and I agree it isn't straightforward. The use case I was thinking of would be to tag a set of files with the same tag and value, maybe just two files that are adjacent in the same folder or maybe an entire sub-folder of files. For example, if I was tagging site codes on a set of camera trap images and I had organized my images in subfolders by site, I could imagine wanting to tag a set of files all at once.

prabhuramachandran commented 5 years ago

Hi @amoeba,

Thanks again for a specific use case. This is a very useful idea indeed, we will keep this in mind for a subsequent release. I have also expanded the support section a bit in #25. In addition, I also just pushed a bug report template to make it easier for users to report problems and provide the necessary information. I hope this is enough, please let me know if #25 is good enough and I can merge it, otherwise I will add to that PR with any suggestions you may have.

Thanks again!

amoeba commented 5 years ago

Looks great, thanks @prabhuramachandran ! All set here.