search

viz-rs / path-tree

path-tree is a lightweight high performance HTTP request router for Rust
Apache License 2.0
119 stars 18 forks source link

A lazy `Iterator` variant of `Path::params` #24

Closed Txuritan closed 1 year ago

Txuritan commented 1 year ago

This worked out great for the Python wrapper: https://github.com/adriangb/routrie/commit/faa4ad8bf2a10a06ed621eb1e30a5d4cceb5cc91#diff-b1a35a68f14e696205874893c07fd24fdb88882b47c23cc0e0c80a30c7d53759

It would be nice to figure out at some point how to lazily build the parameters instead of calling params() (just like you are doing in Rust) before returning the data to Python, but I suspect it would get pretty complicated again with lifetimes for probably little benefit to users.

Originally posted by @adriangb in https://github.com/viz-rs/path-tree/issues/22#issuecomment-1256553651

As mentioned a Iterator variant of Path::params might be useful. So I had a go at it and managed to get a version working using a custom Iterator type. The downside is that it requires a brittle typed iterator chain.

Would like some feedback on this as it would be quite useful to remove the ending allocation but its quite verbose and may be hard to use.

adriangb commented 1 year ago

That is very cool. Unfortunately we will not be able to use it from python because you can’t return anything with a lifetime. But probably something interesting to explore for the rust side!

Txuritan commented 1 year ago

My initial idea for that was to somehow Box the Iterator and create a custom PyO3 class to act as the Iterator, like a generator/yield. But that might not be possible due to just how many lifetimes are required to avoid cloning data.

fundon commented 1 year ago

I think they will eventually be converted to the following types in most scenarios.

  1. (&'a str, &'b str) => (String, String)
  2. (&'a str, &'b str) => (Arc<str>, Arc<str>)