vizdata-f21 / project-2-tidy_team

https://vizdata-f21.github.io/project-2-tidy_team/
0 stars 2 forks source link

Maps time slider and play button #12

Closed drewf24 closed 2 years ago

drewf24 commented 2 years ago

Hi @mine-cetinkaya-rundel!

We were putting final touches on our app this morning getting ready to deploy and the "play" button on our map which animates the time slider somehow stopped working.

The maps loads a lot faster, but we are unable to see it over multiple years. Any chance you can take a look?

Thanks

kathrynthomas commented 2 years ago

Hello @mine-cetinkaya-rundel

For further detail, we are using the animation_opts() argument within the plotly package to create the time scale animation/year select function.

For the air pollution map, this line of code is found on line 236 of the app.R (now located within the death_risk_factors folder.

Additionally, this function requires that we include frame = "year" within the aesthetic (aes_string) function of the original ggplot. For the first map (air pollution), this is located on line 207.

The functionality has worked previously, so we believe this approach should work.

Thank you so much for all your guidance and help de-bugging, we really appreciate it!

mine-cetinkaya-rundel commented 2 years ago

I'll try to take a look at 11am. If that meeting needs more of my attention I'll come back to it ~2pm and update here.

mine-cetinkaya-rundel commented 2 years ago

I'm trying to navigate the repo to find where I can help but I'm unsure.

I tried running app.R under shiny_app but the required data isn't there. Which file should I be looking in?

kathrynthomas commented 2 years ago

@mine-cetinkaya-rundel

Sorry for the confusion! We have moved files today to prepare to deploy the app.

Our app is within the death_risk_factors folder, titled app.R

The data cleaning script, data-cleaning.R (which has to be run first) is in the data folder within death_risk_factors

kathrynthomas commented 2 years ago

Closed, we utilized the height = "600px" function in plotlyOutput to resolve this issue.