vizhub-core / vizhub-feedback

VizHub feedback issue tracker
32 stars 3 forks source link

Expose Svelte CSS Output #676

Closed curran closed 2 years ago

curran commented 3 years ago

The last remaining task for Svelte integration is to expose the CSS outout on the page.

Possible Approaches:

Considerations:

curran commented 3 years ago

Oh hey! sveltejs/template uses the name bundle.css. How appropriate.

image

And in that template, index.html explicitly pulls in that generated file like so:

<link rel='stylesheet' href='/build/bundle.css'>  
curran commented 3 years ago

bundle.css seems the way to go.

So this means we'll need to introduce almost exactly the same logic as is there for bundle.js, applied to generating bundle.css. This includes all the hairy logic around ignoring remote changes (only re-generating the file when local changes are made).

This may be a substantial effort.

curran commented 3 years ago

Added Launch Blocker tag as this is the last thing we need before announcing Svelte support.