search

vizhub-core / vizhub-feedback

VizHub feedback issue tracker
32 stars 3 forks source link

[package.json] Make Image Generation Service Work #695

Closed curran closed 3 years ago

curran commented 3 years ago

Currently, the image generation for vizzes that use package.json appears not to work.

Reproduction: https://vizhub.com/curran/161a5fcfe2e148f583cc75efb8ab3255

curran commented 3 years ago

First lead: 

TypeError: Cannot read property 'parseFromString' of undefined
    at injectBundleScript (/home/curran/repos/vizhub/packages/presenters/src/getComputedIndexHtml.js:26:22)
curran commented 3 years ago

Oh! I think we just need to use setJSDOM from image generation service.