search

vizhub-core / vizhub-feedback

VizHub feedback issue tracker
32 stars 3 forks source link

Fork count seems wrong #722

Open nitanagdeote opened 3 years ago

nitanagdeote commented 3 years ago

On map viz the fork count seems wrong for this user( image attached) wrong_no_of_forks_on_map_viz

curran commented 3 years ago

My first thought is, private forks are included in the count, but not in the listing.

Also there is a chance that the data could be wrong (the way we backfilled those values was a bit ... sketchy - could do it again).

Idea: Include something in the forks page that says how many private forks there are, but not include any info on who forked them.

curran commented 3 years ago

The issue is that the forks count includes private forks.

Should it?

Maybe it should only show the number of public forks?

I wonder what GitHub does...

If it shows the total that includes private forks, then the existence of those forks is not actually ... private. In a way this is leaking out private information (the fact that the viz was forked at all).