Private Vizes page: Clicking on the "most recent" option takes to the public viz page

vizhub-core / vizhub-feedback

VizHub feedback issue tracker

32 stars 3 forks source link

Closed nitanagdeote closed 3 years ago

nitanagdeote commented 3 years ago

"most recent" is not working

curran commented 3 years ago

I can reproduce:

The technical issue is perhaps that the route is changed in two places, the sort order and the section, and these don't talk to one another.

Suggestion for approach: unify the routing logic, in the same style as the viz page.

See src/pages/VizPage/URLStateContext/reducer.js for the pattern that we can perhaps use for the profile page as well.

curran commented 3 years ago

I'd be happy to copy-paste the overall structure of URLStateContext for the profile page.