search

vizhub-core / vizhub-legacy

Data Visualization Platform
https://vizhub.com
MIT License
90 stars 44 forks source link

consolidate search state updates #478

Closed stushurik closed 3 years ago

stushurik commented 3 years ago

closes datavis-tech/vizhub-issue-tracker/issues/724

curran commented 3 years ago

Thanks for the follow-up! Deploying to staging...

curran commented 3 years ago

Did QA on staging. The sort entry issue is fixed, but now I notice another thing.

image

Search within a profile now is not working.

Reproduction: https://staging.vizhub.com/curran?query=opacity

curran commented 3 years ago

Actually, navigating to this link has the correct expected behavior https://staging.vizhub.com/curran?query=opacity

To reproduce, enter some text in the search box and hit enter. Observe that the listing does not change.

curran commented 3 years ago

Merging this as the fix for public/private is great to have. We can fix the search-in-profile issue later.