vizhub-core / vizhub-legacy

Data Visualization Platform
https://vizhub.com
MIT License
89 stars 44 forks source link

Fix error with updating viz with no index.js #508

Closed curran closed 2 years ago

curran commented 2 years ago

This PR fixes a glitch that happens when repeatedly updating a viz that does not have an index.js.

Bug first observed here https://vizhub.com/alark/290a1c583f024d01b7a852d12fefbf94

The error looks like this.

image

It was happening because the runner logic was trying to delete bundle.js, but bundle.js did not exist.

This PR makes it so that the runner logic only attempts to delete bundle.js if it exists.