search

vizzuhq / vizzu-lib

Library for animated data visualizations and data stories.
https://lib.vizzuhq.com
Apache License 2.0
1.9k stars 81 forks source link

Chart onChange and rendering connection moved to TS API #509

Closed simzer closed 6 months ago

schaumb commented 6 months ago

When a resize happens, it needs to call Chart::doChange on the "ts" side. Would you like to change that in this PR?

simzer commented 6 months ago

Checking size change inside wasm was obsolate, since size in wasm only got updated when needsUpdate was already queried.

simzer commented 6 months ago

@schaumb No, on a second tought, i don't wan't to change the current size handling, because currently we force a redraw immediately if the canvas size changed. If we set the needsUpdate flag instead, it will only be redrawn when the next rendering scheduled, hance there migth be a visible delay on rendering refresh when we rescale the canvas.