search

vjcitn / rhdf5client

2 stars 1 forks source link

support of scalar values #5

Closed assaron closed 1 year ago

assaron commented 1 year ago

Hi,

Here is patch that fixes errors for H5 scalar values: there is no shape defined for them automatically, so I've made it to be just 1.

Here is the version merged with the compound support patch: https://github.com/assaron/rhdf5client

vjcitn commented 1 year ago

Maybe I messed up by merging the earlier PR that I had not seen. Now I see conflicts. Can you issue a new PR against the current code base?

assaron commented 1 year ago

Pushed my merged version here

vjcitn commented 1 year ago

the changes will be pushed into the bioconductor codebase soon

On Wed, Apr 19, 2023 at 5:26 PM Alexey Sergushichev < @.***> wrote:

Pushed my merged version here

— Reply to this email directly, view it on GitHub https://github.com/vjcitn/rhdf5client/pull/5#issuecomment-1515405936, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDI5QSOJU446TGEREMVORLXCBKBHANCNFSM6AAAAAAXER6NJ4 . You are receiving this because you commented.Message ID: @.***>

-- The information in this e-mail is intended only for the person to whom it is addressed. If you believe this e-mail was sent to you in error and the e-mail contains patient information, please contact the Partners Compliance  HelpLine at http://www.partners.org/complianceline http://www.partners.org/complianceline . If the e-mail was sent to you in error but does not contain patient information, please contact the sender and properly dispose of the e-mail.