search

vjcitn / rhdf5client

2 stars 1 forks source link

support for unsigned int type #7

Closed assaron closed 3 months ago

assaron commented 9 months ago

I've added support for unsigned type. It has the same limitation as current int64 support - there will be overflow without a warning.

assaron commented 9 months ago

Here is an archive with the test h5 file.

test_numbers.zip

assaron commented 9 months ago

@vjcitn reminding you about this PR

vjcitn commented 3 months ago

is this still needed?

assaron commented 3 months ago

Yes!

assaron commented 3 months ago

@vjcitn Do you need some help with this? I think it should be still in a good shape, but let me know if I should do anything

vjcitn commented 3 months ago

Sorry for the delay on this. I synchronized main branch of my repo with bioconductor git. Can you look at the version number in DESCRIPTION, case of biocViews field, and revise PR a little then I will merge and then update bioconductor

assaron commented 3 months ago

I've updated the version. Not sure what you meant about biocViews, it looks to be correct.

One thing to note is that the tests are failing in this version, as they require test_numbers.h5 file to be uploaded to the HSDS. This is the archive with the file: https://github.com/vjcitn/rhdf5client/files/12564029/test_numbers.zip

vjcitn commented 3 months ago

the numbers file was added to hsds and the PR was merged and ported to bioconductor git

assaron commented 3 months ago

Great, thank you!