vjcitn / rhdf5client

2 stars 1 forks source link

Added `type` slot for HSDSFile #8

Closed assaron closed 2 months ago

assaron commented 2 months ago

Hi Vincent,

This PR adds support for HSDSFile to represent a directory. It kind of worked before as well, but complained about "no datasets".

I'm not sure about your plans about HSDSFile() vs .HSDSFile(), so I modified both of them.

vjcitn commented 2 months ago

Alexey are you interested in taking over maintenance of this package?

vjcitn commented 2 months ago

I think your most recent PRs are in the devel branch now. Looks like I missed the type change for 3.19 ... it could go in if necessary

assaron commented 2 months ago

Thanks!

Looks like I missed the type change for 3.19 ... it could go in if necessary

No need, it's not urgent.

Alexey are you interested in taking over maintenance of this package?

Yeah, I think I can do this, no problem.