vjdorazio / TwoRavens

A web application for data exploration, statistical analysis, model construction and meta analysis tools, that integrates with Zelig and Dataverse.
http://datascience.iq.harvard.edu/tworavens
Other
1 stars 4 forks source link

rooksubset.app crashes on o_196 seed data #19

Open tercer opened 6 years ago

tercer commented 6 years ago

Any attempt to subset variables using the o_196 dataset gives an error:

Error in if (nc == "character") { : argument is of length zero

The line within rooksubset that is failing is: https://github.com/vjdorazio/TwoRavens/blob/dbee2a129c5c93677479408efe4b5bf85ad7e271/rook/rooksubset.R#L121

Because the data that is being passed for a new round of preprocessing in empty.

tercer commented 6 years ago

Some of the problem seems to be that the dataset is hardcoded in rooksubset when not in production: https://github.com/vjdorazio/TwoRavens/blob/dbee2a129c5c93677479408efe4b5bf85ad7e271/rook/rooksubset.R#L44-L50

However, fixing that is not sufficient.