Fix: concurrent map read and map write - Githubissues

vjeantet / ldapserver

Package ldapserver implements LDAP Server

MIT License

249 stars 93 forks source link

Fix: concurrent map read and map write #28

Open datastream opened 5 years ago

datastream commented 5 years ago

c.requestList should be protected by mutex lock.

https://github.com/vjeantet/ldapserver/blob/479fece7c5f15b209e2e3ba082a89d18cd2a8207/client.go#L42 `diff --git a/client.go b/client.go index a174d36..665743d 100644 --- a/client.go +++ b/client.go @@ -39,9 +39,12 @@ func (c *client) SetConn(conn net.Conn) { }

func (c client) GetMessageByID(messageID int) (Message, bool) {

c.mutex.Lock() if requestToAbandon, ok := c.requestList[messageID]; ok {
c.mutex.Unlock() return requestToAbandon, true }
c.mutex.Unlock() return nil, false }`