search

vjpai / grpc-tutorial

Tutorial for building microservices with gRPC
Apache License 2.0
5 stars 1 forks source link

Communication models and microservice-based design #6

Closed vjpai closed 7 years ago

vjpai commented 7 years ago

I think I fixed all reviewer comments. PTAL. Thanks!

dgquintas commented 7 years ago

It helps to not amend previous commits until the end: it makes it harder to look at incremental changes.

abhisekpan commented 7 years ago

Hi Vijay,

Just a suggestion! in this slide / page, https://github.com/vjpai/grpc-tutorial/blob/master/slides/parallel-models.md, in platforms - maybe add peer-to-peer systems, and also grid-computing systems.

Thanks! Abhisek

On Fri, Mar 3, 2017 at 5:30 PM, Vijay Pai notifications@github.com wrote:

Merged #6 https://github.com/vjpai/grpc-tutorial/pull/6.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vjpai/grpc-tutorial/pull/6#event-986295194, or mute the thread https://github.com/notifications/unsubscribe-auth/AByoWRgPDVhp8Yl0Th3eOIMf_BvAU1aLks5riL6ogaJpZM4MQoMl .

-- Abhisek Live Long and Prosper

vjpai commented 7 years ago

Hey long time no see! Would you like to contribute a paragraph?

On Fri, Mar 3, 2017, 5:48 PM Abhisek notifications@github.com wrote:

Hi Vijay,

Just a suggestion! in this slide / page,

https://github.com/vjpai/grpc-tutorial/blob/master/slides/parallel-models.md , in platforms - maybe add peer-to-peer systems, and also grid-computing systems.

Thanks! Abhisek

On Fri, Mar 3, 2017 at 5:30 PM, Vijay Pai notifications@github.com wrote:

Merged #6 https://github.com/vjpai/grpc-tutorial/pull/6.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vjpai/grpc-tutorial/pull/6#event-986295194, or mute the thread < https://github.com/notifications/unsubscribe-auth/AByoWRgPDVhp8Yl0Th3eOIMf_BvAU1aLks5riL6ogaJpZM4MQoMl

.

-- Abhisek Live Long and Prosper

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/vjpai/grpc-tutorial/pull/6#issuecomment-284116775, or mute the thread https://github.com/notifications/unsubscribe-auth/AIdEkLADXQH6mw_VvGJ5aYrc3CIWOvXsks5riMLkgaJpZM4MQoMl .

abhisekpan commented 7 years ago

About these additions- sure I can do that!

Sent from my iPhone (765-464-9422)

On Mar 3, 2017, at 6:24 PM, Vijay Pai notifications@github.com wrote:

Hey long time no see! Would you like to contribute a paragraph?

On Fri, Mar 3, 2017, 5:48 PM Abhisek notifications@github.com wrote:

Hi Vijay,

Just a suggestion! in this slide / page,

https://github.com/vjpai/grpc-tutorial/blob/master/slides/parallel-models.md , in platforms - maybe add peer-to-peer systems, and also grid-computing systems.

Thanks! Abhisek

On Fri, Mar 3, 2017 at 5:30 PM, Vijay Pai notifications@github.com wrote:

Merged #6 https://github.com/vjpai/grpc-tutorial/pull/6.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/vjpai/grpc-tutorial/pull/6#event-986295194, or mute the thread < https://github.com/notifications/unsubscribe-auth/AByoWRgPDVhp8Yl0Th3eOIMf_BvAU1aLks5riL6ogaJpZM4MQoMl

.

-- Abhisek Live Long and Prosper

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/vjpai/grpc-tutorial/pull/6#issuecomment-284116775, or mute the thread https://github.com/notifications/unsubscribe-auth/AIdEkLADXQH6mw_VvGJ5aYrc3CIWOvXsks5riMLkgaJpZM4MQoMl .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.