search

vjuranek / docker-build-step-plugin

Other
8 stars 97 forks source link

Update to recent docker-java #27

Open vjuranek opened 9 years ago

vjuranek commented 9 years ago

preferable to 2.x version

davidcarboni commented 8 years ago

I'm running Docker builds behind a proxy and need to be able to pass 'http_proxy' configuration for this as per:

https://github.com/docker/docker/issues/14634

I've tried implementing functionality for this, but can see the docker-java client added support for build arguments in 3.0.0 (RC4 at the time of writing). It looks like 3.0.0 introduces breaking changes that means it's not a simple update (e.g. Exceptions have moved to a sub-package and there are callbacks to implement).

If I can +1 the plugin being updated to 'docker-java' 3.0.0, this would make it relatively straightforward to contribute build argument functionality.

kevinchabreck commented 8 years ago

@davidcarboni attempted to do this in #45

kevinchabreck commented 8 years ago

45 was merged so this should be possible now.