Closed gered closed 7 years ago
Made a mistake. Not ready yet. I meant to make a PR against my own repository, not yours. Still working on some polish, etc and needs more testing before I'd want to submit a PR to you. Again, sorry!
/facepalm
Great work anyway! I'm so glad you're cleaning the API and possibly develeping it even more. I'm quite busy recently, but will try to work on the current issues later.
Wishing you all the best :)
Thanks! Yeah, my biggest concern with this project was being able to actually build it in the first place, heh. :) So cleaning up on that front was priority number 1. I think it's in a pretty good spot right now, but want to test out the process on another machine first to make sure it also works there and then clean up the documentation.
Beyond that, my original reason for even looking at this code in the first place was to do some very minor fixes to Mirror.startGame
to make it a bit more friendly in a typical Clojure development workflow. I was intending on using this library to work on bots using Clojure. Right now the fact that startGame
always runs an infinite loop (even if you leave the game intentionally... it just tries to connect again right away) is kind of a pain in the ass for a REPL-based development workflow where you're reloading code, etc instantly. Basically the only way to actually stop startGame
right now is to stop the JVM process since you cannot terminate the thread any other way... which is really annoying!