search

vjurenka / BWMirror

BWMirror API source files
Other
55 stars 13 forks source link

Minor bug fix with copying .dll files. #14

Closed muandrew closed 9 years ago

muandrew commented 9 years ago

Just makes sure that the decodedPath is being used when creation JarResources so that whitespace and other fun characters will not cause an issue.

Also made a minor improvement by prevent JarResource from being created more than once. Also, if for some reason a file is not found, do not create a zero byte version of it.

muandrew commented 9 years ago

Closing because I read the README more carefully, this change should be suggested in the generator project.

vjurenka commented 9 years ago

Yup, thanks for the contribution, but the actual change should be made to the Mirror.java in the generator (the project is quite messy though :blush: )

Here's the link to the "original" Mirror.java: https://github.com/vjurenka/BWMirror-Generator/blob/master/manual-bwapi4/Mirror.java